lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] [media] firewire: Deletion of an unnecessary check before the function call "dvb_unregister_device"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 20 Nov 2014 10:49:07 +0100

    The dvb_unregister_device() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/firewire/firedtv-ci.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/firewire/firedtv-ci.c b/drivers/media/firewire/firedtv-ci.c
    index e5ebdbf..e63f582 100644
    --- a/drivers/media/firewire/firedtv-ci.c
    +++ b/drivers/media/firewire/firedtv-ci.c
    @@ -253,6 +253,5 @@ int fdtv_ca_register(struct firedtv *fdtv)

    void fdtv_ca_release(struct firedtv *fdtv)
    {
    - if (fdtv->cadev)
    - dvb_unregister_device(fdtv->cadev);
    + dvb_unregister_device(fdtv->cadev);
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 11:21    [W:4.215 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site