lkml.org 
[lkml]   [2014]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/3] [media] DVB-frontends: Deletion of unnecessary checks before the function call "release_firmware"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 19 Nov 2014 22:27:24 +0100

    The release_firmware() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/dvb-frontends/drx39xyj/drxj.c | 3 +--
    drivers/media/dvb-frontends/drxk_hard.c | 3 +--
    drivers/media/dvb-frontends/m88ds3103.c | 3 +--
    drivers/media/dvb-frontends/si2168.c | 3 +--
    4 files changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dvb-frontends/drx39xyj/drxj.c
    index 7ca7a21..08e6ca5 100644
    --- a/drivers/media/dvb-frontends/drx39xyj/drxj.c
    +++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c
    @@ -12255,8 +12255,7 @@ static void drx39xxj_release(struct dvb_frontend *fe)
    kfree(demod->my_ext_attr);
    kfree(demod->my_common_attr);
    kfree(demod->my_i2c_dev_addr);
    - if (demod->firmware)
    - release_firmware(demod->firmware);
    + release_firmware(demod->firmware);
    kfree(demod);
    kfree(state);
    }
    diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c
    index cce94a7..f871478 100644
    --- a/drivers/media/dvb-frontends/drxk_hard.c
    +++ b/drivers/media/dvb-frontends/drxk_hard.c
    @@ -6309,8 +6309,7 @@ static void drxk_release(struct dvb_frontend *fe)
    struct drxk_state *state = fe->demodulator_priv;

    dprintk(1, "\n");
    - if (state->fw)
    - release_firmware(state->fw);
    + release_firmware(state->fw);

    kfree(state);
    }
    diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
    index dfe0c2f..e88f0f6 100644
    --- a/drivers/media/dvb-frontends/m88ds3103.c
    +++ b/drivers/media/dvb-frontends/m88ds3103.c
    @@ -637,8 +637,7 @@ skip_fw_download:

    return 0;
    err:
    - if (fw)
    - release_firmware(fw);
    + release_firmware(fw);

    dev_dbg(&priv->i2c->dev, "%s: failed=%d\n", __func__, ret);
    return ret;
    diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
    index 8f81d97..6a455f9 100644
    --- a/drivers/media/dvb-frontends/si2168.c
    +++ b/drivers/media/dvb-frontends/si2168.c
    @@ -469,8 +469,7 @@ static int si2168_init(struct dvb_frontend *fe)

    return 0;
    err:
    - if (fw)
    - release_firmware(fw);
    + release_firmware(fw);

    dev_dbg(&s->client->dev, "%s: failed=%d\n", __func__, ret);
    return ret;
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-20 10:01    [W:4.021 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site