lkml.org 
[lkml]   [2014]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Documentation: Restrict TSC test code to x86


On 02.11.14 08:46, Matwey V. Kornilov wrote:
> I wish I knew. We need KBuild guru to ask how to take into account
> host architecture.

Hrm. At least this patch makes things more consistent with the other
Documentation makefiles:

Documentation/timers/Makefile:hostprogs-$(CONFIG_X86) := hpet_example
Documentation/vDSO/Makefile:hostprogs-$(CONFIG_X86) :=
vdso_standalone_test_x86

But I agree, it is wrong in general - hostprogs should make sure the
host arch matches.

We could maybe just evaluate the host uname output:

ifeq ($(shell uname -m),x86_64)
hostprogs-$(CONFIG_X86) := ...
endif

Then we're double safe ;). Not sure how to easily add x86 to the mix as
well here, but I'm not sure anyone cares. Do people still compile on
32bit x86 hosts? And expect Documentation/ examples to build?


Alex


\
 
 \ /
  Last update: 2014-11-02 09:41    [W:1.453 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site