lkml.org 
[lkml]   [2014]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.
From
From: Clemens Ladisch <clemens@ladisch.de>
Date: Sun, 02 Nov 2014 21:15:12 +0100

> Kernel code assumes that the PAGE_* values are preprocessor symbols, and
> that therefore arch support can be checked for with #ifdef.
>
> At the moment, sparc64 does not implement any of the symbols checked
> for, so these checks happen to work.
>
> To prevent potential breakage when another #ifdef check is added or when
> sparc64 implements another PAGE_ value, make such #ifdef checks work by
> adding preprocessor symbols on top of the PAGE_* variables.
>
> Signed-off-by: Clemens Ladisch <clemens@ladisch.de>

"This change actually doesn't have any effect, and doesn't matter,
so let's make this change."

I really don't buy this.

I'd also rather the kernel use Kconfig based symbols to detect for
arch availability of feature X or Y, assuming things are CPP symbols
is very fragile at best.

I'm not applying this, sorry. I mean, you didn't even bother to
mention what symbol this does matter for.



\
 
 \ /
  Last update: 2014-11-03 00:41    [W:0.045 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site