Messages in this thread | | | Date | Sun, 2 Nov 2014 23:53:07 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH net-next v2 2/3] r8152: clear the flagofSCHEDULE_TASKLET in tasklet |
| |
Hayes Wang <hayeswang@realtek.com> : > David Miller [davem@davemloft.net] [...] > > If another thread of control sets the bit between the test and the > > clear, you will lose an event. > > It is fine. The flag is used to schedule a tasklet, so if the tasklet is > starting running, all the other plans for scheduling a tasklet could > be cleared.
test_and_clear_bit (dense) or clear_bit would be more idiomatic.
-- Ueimor
| |