lkml.org 
[lkml]   [2014]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 026/122] audit: keep inode pinned
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Miklos Szeredi <mszeredi@suse.cz>

    commit 799b601451b21ebe7af0e6e8f6e2ccd4683c5064 upstream.

    Audit rules disappear when an inode they watch is evicted from the cache.
    This is likely not what we want.

    The guilty commit is "fsnotify: allow marks to not pin inodes in core",
    which didn't take into account that audit_tree adds watches with a zero
    mask.

    Adding any mask should fix this.

    Fixes: 90b1e7a57880 ("fsnotify: allow marks to not pin inodes in core")
    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    Signed-off-by: Paul Moore <pmoore@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    kernel/audit_tree.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/kernel/audit_tree.c
    +++ b/kernel/audit_tree.c
    @@ -154,6 +154,7 @@ static struct audit_chunk *alloc_chunk(i
    chunk->owners[i].index = i;
    }
    fsnotify_init_mark(&chunk->mark, audit_tree_destroy_watch);
    + chunk->mark.mask = FS_IN_IGNORED;
    return chunk;
    }




    \
     
     \ /
      Last update: 2014-11-19 23:41    [W:3.944 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site