Messages in this thread | | | Date | Wed, 19 Nov 2014 19:23:36 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight |
| |
On Wed, Nov 19, 2014 at 10:34:16AM -0800, Darren Hart wrote:
> I'm somewhat concerned that this patch doubles the size of this driver. When > we're adding this much code, I have to ask - does it make sense to grow this > driver rather than create a new one?
There'd be a fair amount of code duplication in splitting it.
> There is no ACPI backlight driver on these systems? We need a platform driver?
ACPI doesn't specify keyboard backlight control, so this ends up being very vendor specific.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |