Messages in this thread | | | Date | Wed, 19 Nov 2014 17:47:09 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards |
| |
On Wed, Nov 19, 2014 at 09:19:13AM -0800, Doug Anderson wrote:
Please stop CCing my work address for upstream things.
> On Wed, Nov 19, 2014 at 2:07 AM, Javier Martinez Canillas
> > I see, I thought that it was a common practice in the mainline kernel > > too since I saw that many board DTS currently have a spidev node:
> > $ git grep 'compatible = "spidev"' arch/arm/boot/dts/ | wc -l > > 19
These are bugs. The device tree should describe the hardware, spidev is a Linux implementation detail. Provide a compatible string for the device that is there just as you would for any other device.
> OK. Please don't take my comments as a NAK on this patch. I should > have done the same grep myself before sending--sorry. I just > remembered the old conversation and looked for that instead.
Please take this as one. [unhandled content-type:application/pgp-signature] | |