Messages in this thread | | | Date | Wed, 19 Nov 2014 10:01:08 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/2] tracing: Use trace_seq_used() and seq_buf_used() instead of len |
| |
On Wed, 19 Nov 2014 15:40:05 +0100 Petr Mladek <pmladek@suse.cz> wrote:
> > s->seq.len will never be more than s->seq.size after the test against > > TRACE_MAX_PRINT. So I see no harm here. > > Ah, I see. Well, I would feel more comfortable if it uses > trace_seq_used() or if there is some explanation in a comment. > But you are right, it is safe as it is. Feel free to leave it.
Yeah, a comment would be nice. I may add it late.
> > Reviewed-by: Petr Mladek <pmladek@suse.cz>
Thanks,
-- Steve
| |