lkml.org 
[lkml]   [2014]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 18 Nov 2014 21:41:26 +0100

    The ipcomp_free_tfms() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/xfrm/xfrm_ipcomp.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c
    index ccfdc71..47863cd 100644
    --- a/net/xfrm/xfrm_ipcomp.c
    +++ b/net/xfrm/xfrm_ipcomp.c
    @@ -320,8 +320,7 @@ error:

    static void ipcomp_free_data(struct ipcomp_data *ipcd)
    {
    - if (ipcd->tfms)
    - ipcomp_free_tfms(ipcd->tfms);
    + ipcomp_free_tfms(ipcd->tfms);
    ipcomp_free_scratches();
    }

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-18 22:21    [W:4.050 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site