lkml.org 
[lkml]   [2014]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] perf, tools: Add --branch-history option to report
On Mon, Nov 17, 2014 at 03:31:57PM +0900, Namhyung Kim wrote:
> On Wed, 12 Nov 2014 01:05:05 +0100, Andi Kleen wrote:
> >> And please also add a new CCKEY_SRCLINE if you print srcline with the
> >> callchains so that users can give "-g srcline" if they want (regardless
> >> of the branch history feature).
> >
> > That would be largely identical to CCKEY_ADDRESS
> > except for the case of two calls to the same function from
> > the same line. Probably not worth adding?
>
> For sorting, yes, it'd be almost identical. But what I'm saying is for
> printing - IOW print callchain entries with symbol and srcline (for
> normal perf report too).

But I thought the key is only for sorting?

I already added an option to print the src line and it should
work for normal perf report.

-Andi


\
 
 \ /
  Last update: 2014-11-18 03:41    [W:0.117 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site