Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] ACPI / GPIO: Driver GPIO mappings for ACPI GPIOs | Date | Tue, 18 Nov 2014 00:31:23 +0100 |
| |
On Monday, November 17, 2014 01:28:54 PM Alexandre Courbot wrote: > On Fri, Nov 14, 2014 at 5:58 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Nov 3, 2014 at 11:56 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > >> On Monday, November 03, 2014 02:22:10 PM Linus Walleij wrote: > > > >>> With that change: > >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > >> > >> OK, made the changes and added your Reviewed-by. > >> > >> One semi-related question though. Alexandre ACKed the patch before, so > >> what did that mean from the GPIO subsystem's perspective? Was the patch > >> approved, not approved, semi-approved? > > > > It just means we are not always entirely aligned, it's not like > > Alexandre and I have meetings on the side and decide what to > > say, it's just these mails. I do trust him, I wouldn't get mad if it > > had been merged just wanted some polishing when I could get > > it... > > In case of conflicting feedback between me and Linus, it goes without > saying that Linus' opinion should prevail. I am trying to help a bit > and take some of the burden off his shoulders, but have neither his > skill nor his experience (which shows when you compare our patch > reviews). So for important stuff it is a good idea to wait until both > of us give a ack - the most likely conflict scenario being that I give > a pass overlooking something that Linus will catch.
Thanks for the clarification!
Rafael
| |