Messages in this thread | | | Date | Mon, 17 Nov 2014 17:07:06 -0500 | From | Benjamin Tissoires <> | Subject | Re: [PATCH] HID: i2c-hid: fix race condition reading reports |
| |
On Nov 17 2014 or thereabouts, Greg KH wrote: > On Mon, Nov 17, 2014 at 04:43:05PM -0500, Benjamin Tissoires wrote: > > Hey Antonio, > > > > On Nov 16 2014 or thereabouts, Antonio Borneo wrote: > > > From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> > > > > > > From: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> > > > > > > Current driver uses a common buffer for reading reports either > > > synchronously in i2c_hid_get_raw_report() and asynchronously in > > > the interrupt handler. > > > There is race condition if an interrupt arrives immediately after > > > the report is received in i2c_hid_get_raw_report(); the common > > > buffer is modified by the interrupt handler with the new report > > > and then i2c_hid_get_raw_report() proceed using wrong data. > > > > > > Fix it by using a separate buffers for asynchronous reports. > > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> > > > [Antonio Borneo: cleanup and rebase to v3.17] > > > Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> > > > Cc: stable@vger.kernel.org > > > > For your next submission, when you want a patch to go in stable, put CC > > here, but please do not CC the actual mail to stable@. Stable should receive > > either mails which are already in Linus' tree, or which refer a commit > > in Linus' tree in case it does not applies smoothly. > > > > [keeping stable@ here to show them that this one should not get picked > > right now] > > stable@ is smarter than that, I don't mind seeing patches that are > coming in the future like this at all, it's not a problem. >
OK. Sorry for the noise then. I assumed that if everybody starts sending potential patches to stable without them being the accepted ones, you will end up having to deal with a lot more workload that you already have.
And just to be sure that there is no misinterpretation, I did not wanted to imply that stable was not smart enough to deal with such patches... I really appreciate the work done and my concern was to not add workload.
Cheers, Benjamin
> thanks, > > greg k-h
| |