Messages in this thread | | | Subject | Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks | From | Davidlohr Bueso <> | Date | Mon, 17 Nov 2014 12:52:10 -0800 |
| |
On Mon, 2014-11-17 at 20:08 +0100, Manfred Spraul wrote: > Hi Steven, > > On 11/16/2014 08:40 PM, Steven Stewart-Gallus wrote: > > Finally, please don't ignore the rest of my message. Even if my patch > > isn't that good there are lots of ways to compromise and improve it > > such as adding tests, annotations and making it clearer. > > I think you were already given ideas how to improve the patch: > > a) split the patch. > > b) create test cases so that you are able to check that the code still > behaves as it did before
Adding/improving ipc kselftests would also be very welcome.
Thanks, Davidlohr
| |