lkml.org 
[lkml]   [2014]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks
From
Date
On Mon, 2014-11-17 at 20:08 +0100, Manfred Spraul wrote:
> Hi Steven,
>
> On 11/16/2014 08:40 PM, Steven Stewart-Gallus wrote:
> > Finally, please don't ignore the rest of my message. Even if my patch
> > isn't that good there are lots of ways to compromise and improve it
> > such as adding tests, annotations and making it clearer.
>
> I think you were already given ideas how to improve the patch:
>
> a) split the patch.
>
> b) create test cases so that you are able to check that the code still
> behaves as it did before

Adding/improving ipc kselftests would also be very welcome.

Thanks,
Davidlohr



\
 
 \ /
  Last update: 2014-11-17 22:21    [W:0.036 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site