lkml.org 
[lkml]   [2014]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 00/10] Save MSI chip in pci_sys_data
On Mon, Nov 17, 2014 at 2:38 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sun, 16 Nov 2014, Bjorn Helgaas wrote:
>> On Tue, Nov 11, 2014 at 09:23:59PM -0700, Bjorn Helgaas wrote:
>> > On Mon, Oct 27, 2014 at 03:48:37PM +0800, Yijing Wang wrote:
>> > > Yijing Wang (10):
>> > > MSI: Rename msi_chip to msi_controller for better readability
>> > > PCI/MSI: Introduce weak pcibios_msi_controller()
>> > > arm/MSI: Save MSI controller in pci_sys_data
>> > > PCI: tegra: Save MSI controller in pci_sys_data
>> > > PCI: designware: Save MSI controller in pci_sys_data
>> > > PCI: rcar: Save MSI controller in pci_sys_data
>> > > PCI: mvebu: Save MSI controller in pci_sys_data
>> > > PCI: xilinx: Save MSI controller in pci_sys_data
>> > > arm/PCI: Clean unused pcibios_add_bus() and pcibios_remove_bus()
>> > > PCI/MSI: Remove useless bus->msi assignment
>> >
>> > Applied to pci/msi for v3.19, thanks.
>>
>> This series is currently in the pci "next" branch, but the fact that there
>> are so many MSI-related changes from so many people makes me worry that
>> we're heading for a merge problem.
>>
>> Here are the outstanding IRQ- and MSI-related things I've seen:
>>
>> Marc 10/25 [00/03] genirq: Add support for "split-EOI" irqchips
>> Yijing 10/27 [00/10] Save MSI chip in pci_sys_data
>> Yijing 10/27 [00/16] Use MSI controller framework to configure MSI/MSI-X
>> Jiang 10/27 [Part1 v3 00/20] Prepare for enabling hierarchy irqdomain on x86
>> Jiang 11/02 [v8 00/18] Enable support of IOAPIC hotplug on x86 platforms
>> Jiang 11/06 [Part2 v5 00/31] Enable hierarchy irqdomian on x86 platforms
>> Jiang 11/09 [Part3 v3 00/38] Enable hierarchy irqdomian on x86 platforms
>> Marc 11/11 [00/15] arm64: PCI/MSI: GICv3 ITS support (stacked domain edition)
>> Thomas 11/12 [00/16] genirq: Hierarchical irq domains and generic MSI interrupt code
>> Jiang 11/15 [V2 00/09] Refine generic/PCI MSI irqodmian interfaces
>> Marc 11/15 [00/02] Stacked domains and MSI improvements
>>
>> PCI is only a minor participant, and I certainly don't have the expertise
>> to deal with all this, so I suspect that I should just drop these from the
>> PCI tree and let Thomas deal with them. It seems like it would make more
>> sense to get all this stuff merged together in a single tree rather than
>> having some come via PCI and others come from via other trees.
>
> The simplest way to dead with it is that I pull in pci/msi (assuming
> that it contains only the above) and base the rest of it on top, so I
> can deal with the resulting conflicts. So you still can keep that in
> your pile and no matter who sends the pull request first everything
> will just fall in place.

In addition to the ("Save MSI chip in pci_sys_data") series, my
pci/msi branch contains these:

f83386942702 s390/MSI: Use __msi_mask_irq() instead of default_msi_mask_irq()
03f56e42d03e Revert "PCI: Add x86_msi.msi_mask_irq() and msix_mask_irq()"
38737d82f9f0 PCI/MSI: Add pci_msi_ignore_mask to prevent writes to
MSI/MSI-X Mask Bits

but I don't think it will hurt if you pull in those as well.

The bigger problem might be the first patch of the "Save MSI chip in
pci_sys_data", which renames "struct msi_chip" to "struct
msi_controller". I asked Yijing to do that because I didn't think
"_chip" really conveyed any information. I didn't know we were going
to have quite this many MSI-related patches to fix up.

So I'll just leave my pci/msi branch as-is for now. If the rename is
too painful, let me know and I'll drop the branch and we can rework
the rest of the "Save MSI chip in pci_sys_data" series to match.

Bjorn


\
 
 \ /
  Last update: 2014-11-17 18:41    [W:0.112 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site