lkml.org 
[lkml]   [2014]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 5/6] Documentation: dt-bindings: Add binding info for X-Gene QMTM UIO driver
Date
On Monday 17 November 2014 16:06:11 Ankit Jindal wrote:
> +
> + qmtm1_uio: qmtm_uio@1f200000 {
> + compatible = "apm,xgene-qmtm";
> + status = "disabled";
> + reg = <0x0 0x1f200000 0x0 0x10000>,
> + <0x0 0x1b000000 0x0 0x400000>;
> + reg-names = "csr", "fabric";
> + qpool-memory = <&qmtm1_uio_qpool>;
> + clocks = <&qmtm1clk 0>;
> + num-queues = <0x400>;
> + devid = <1>;
> + };
> +

To make my previous review comments clearer:

NAK

Do not create device nodes that are meant for a specific use case in
software and that are not usable for the common case. I don't think
it makes any sense to keep on submitting a UIO driver for this until
we have a proper network driver that uses this so we can make sure we
have a working binding.

Arnd


\
 
 \ /
  Last update: 2014-11-17 13:01    [W:0.145 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site