Messages in this thread | | | From | Tomeu Vizoso <> | Date | Thu, 13 Nov 2014 10:36:05 +0100 | Subject | Re: [PATCH v4 04/13] of: document new emc-timings subnode in nvidia,tegra124-car |
| |
On 12 November 2014 15:18, Thierry Reding <thierry.reding@gmail.com> wrote: > On Wed, Nov 12, 2014 at 08:56:27AM +0100, Tomeu Vizoso wrote: > [...] >> Example SoC include file: >> >> / { >> - tegra_car: clock { >> + tegra_car: clock@60006000 { >> compatible = "nvidia,tegra124-car"; >> reg = <0x60006000 0x1000>; >> #clock-cells = <1>; >> @@ -60,4 +83,23 @@ Example board file: >> &tegra_car { >> clocks = <&clk_32k> <&osc>; >> }; >> + >> + clock@60006000 { >> + emc-timings@3 { > > Shouldn't this be following the same naming scheme as the memory > controller's subnodes? > >> + nvidia,ram-code = <3>; >> + >> + timing@12750000 { > > And this?
Thanks for pointing these out. My bad.
Regards,
Tomeu
| |