lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm: mincore: add hwpoison page handle
Date
On Wed, Nov 12, 2014 at 09:20:22AM -0500, Johannes Weiner wrote:
> On Wed, Nov 12, 2014 at 11:39:29AM +0800, Weijie Yang wrote:
> > When encounter pte is a swap entry, the current code handles two cases:
> > migration and normal swapentry, but we have a third case: hwpoison page.
> >
> > This patch adds hwpoison page handle, consider hwpoison page incore as
> > same as migration.
> >
> > Signed-off-by: Weijie Yang <weijie.yang@samsung.com>

Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

>
> The change makes sense:
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> But please add a description of what happens when a poison entry is
> encountered with the current code. I'm guessing swap_address_space()
> will return garbage and this might crash the kernel?

Yes, I think that's correct.

Thanks,
Naoya Horiguchi

\
 
 \ /
  Last update: 2014-11-14 04:01    [W:0.051 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site