Messages in this thread | | | Subject | Re: [PATCH] devcoredump: provide a one-way disable function | From | Johannes Berg <> | Date | Thu, 13 Nov 2014 23:36:25 +0100 |
| |
On Thu, 2014-11-13 at 13:56 -0800, Kees Cook wrote:
> > + /* > > + * This essentially makes the attribute write-once, since you can't > > + * go back to not having it disabled. This is intentional, it serves > > + * as a system lockdown feature. > > + */ > > + if (tmp != 1) > > + return -EINVAL; > > Just a nit, but writing "0" is valid if devcd_disabled = false?
I thought about that too, but what would the point be? The only operation you ever can/want to do is writing "1" to it to disable the framework.
johannes
| |