Messages in this thread | | | Date | Thu, 13 Nov 2014 12:44:48 -0800 | Subject | Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup | From | Benson Leung <> |
| |
On Thu, Nov 13, 2014 at 12:41 PM, Alan Stern <stern@rowland.harvard.edu> wrote: > usbhid_stop probably doesn't need it. And it should be possible to fix > usbhid_close more easily just by interchanging the two lines: > > - usb_kill_urb(usbhid->urbin); > usbhid->intf->needs_remote_wakeup = 0; > + usb_kill_urb(usbhid->urbin); > > Have you tried this?
Yes, I tried that as well, and that does work.
I used the get/put because that's the way it was done in other drivers, for example in synusb_close() in drivers/input/mouse/synaptics_usb.c
-- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org
| |