lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 2/3] power-domain: rockchip: add power doamin driver
On Friday, November 14, 2014 03:35:44 AM Daniel Kurtz wrote:
> On Thu, Nov 13, 2014 at 6:01 AM, Caesar Wang <caesar.wang@rock-chips.com> wrote:
> > +
> > + error = -ENXIO;
> > +
> > + for_each_available_child_of_node(np, node) {
> > + error = rockchip_pm_add_one_domain(pmu, node);
> > + if (error) {
> > + dev_err(dev, "failed to handle node %s: %d\n",
> > + node->name, error);
> > + goto err_out;
> > + }
> > + }
> > +
> > + if (error) {
> > + dev_dbg(dev, "no power domains defined\n");
>
> Perhaps dev_err() or dev_warn(), to ensure this message is seen.
> But, not have defined power domains doesn't seem like a fatal error.
> Perhaps just return 0?

As far as the driver concerned it is a fatal error - the driver can't do
anything when no domain is defined.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2014-11-13 22:01    [W:0.319 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site