Messages in this thread | | | Date | Thu, 13 Nov 2014 15:01:39 -0500 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH V3 5/8] x86: Introduce function to get pmd entry pointer |
| |
On Thu, Nov 13, 2014 at 07:54:57AM +0100, Juergen Gross wrote: > On 11/12/2014 11:12 PM, Konrad Rzeszutek Wilk wrote: > >On Tue, Nov 11, 2014 at 06:43:43AM +0100, Juergen Gross wrote: > >>Introduces lookup_pmd_address() to get the address of the pmd entry > >>related to a virtual address in the current address space. This > >>function is needed for support of a virtual mapped sparse p2m list > >>in xen pv domains. > >> > >What is wrong with using 'lookup_address' ? > > It doesn't return the needed information. I need a pmd entry here, not > a pte entry.
Thank you.
I believe that explanation ought to be part of the commit description.
Could this code be merged with lookup_address_in_pgd - perhaps by having an extra flag that would give it an OK to return the PMD instead of walking down the tree?
Ingo, any preference for this?
Thank you!
| |