lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/10] perf, tools: Support handling complete branch stacks as histograms
On Thu, Nov 13, 2014 at 04:14:17PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 12, 2014 at 06:05:20PM -0800, Andi Kleen escreveu:
> > +static int remove_loops(struct branch_entry *l, int nr)
> > +{
> > + int i, j, off;
> > + unsigned char chash[CHASHSZ];
> > +
> > + memset(chash, NO_ENTRY, sizeof(chash));
> > +
> > + BUG_ON(nr >= 256);
>
> What is wrong with return -1 and propagating the error, so that the user
> is informed if the data being processed is bogus, stop processing with a
> warning or continue processing if finding the next valid record is
> possible?

The error doesn't depend on the record. There is a check for the record
being < 127 in front of this. This is merely to catch that
if someone increases PERF_MAX_BRANCH_DEPTH to below 255 they need
to increase the type of the hash table from u8.


-Andi
--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2014-11-13 21:21    [W:0.084 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site