Messages in this thread | | | Date | Thu, 13 Nov 2014 20:11:17 +0100 | Subject | Re: [PATCH] PM / Domains: restore calling of .suspend/resume_noirq() callbacks | From | Geert Uytterhoeven <> |
| |
On Thu, Nov 13, 2014 at 7:43 PM, Grygorii Strashko <grygorii.strashko@ti.com> wrote: > On 11/13/2014 03:33 AM, Rafael J. Wysocki wrote: >> On Wednesday, November 12, 2014 06:00:47 PM Grygorii Strashko wrote: >>> Now .suspend/resume_noirq() callbacks will not be called during >>> system wide suspend/resume for devices which belongs to some GPD. >>> It seems, that this change was accidentally introduced by >>> commit d23b9b00cdde ("PM / Domains: Rework system suspend callback >>> routines (v2)"). >> >> I'm not sure if that was really accidentally. >> >> Can you describe the problem that the change below is attempting to >> address, without going to much into the history? IOW, what's that >> doesn't work right now? > > There are no real issues - now in Kernel there are no users of GPD > which use "noirq" callbacks.
Indeed.
But as the .suspend_noirq() and .resume_noirq() callbacks are not called when using the generic PM domain, I had to manually handle interrupt disable/enable in commit a00d91ea264f974b ("fbdev: sh_mobile_hdmi: Re-init regs before irq re-enable on resume").
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |