Messages in this thread | | | Date | Thu, 13 Nov 2014 17:44:05 +0000 | From | Mark Brown <> | Subject | Re: [PATCH V2 2/2] spi: Add driver for IMG SPFI controller |
| |
On Wed, Nov 12, 2014 at 07:08:16PM -0800, Andrew Bresticker wrote:
> +#ifdef CONFIG_PM_SLEEP > +static int img_spfi_suspend(struct device *dev) > +{ > + struct spi_master *master = dev_get_drvdata(dev); > + > + return spi_master_suspend(master); > +}
This should really be checking that the device is runtime suspended and disabling the clocks if not, if nothing else someone might be running with !CONFIG_RUNTIME_PM.
One of these days we'll get runtime and system PM playing more frictionlessly but not today. [unhandled content-type:application/pgp-signature] | |