lkml.org 
[lkml]   [2014]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] mfd: arizona: Add support for CS47L24
On Thu, Nov 13, 2014 at 10:12:28AM +0000, Lee Jones wrote:
> On Tue, 11 Nov 2014, Richard Fitzgerald wrote:
>
> > Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> > ---
> > drivers/mfd/Kconfig | 6 +
> > drivers/mfd/Makefile | 3 +
> > drivers/mfd/arizona-core.c | 91 ++-
> > drivers/mfd/arizona-irq.c | 42 +-
> > drivers/mfd/arizona-spi.c | 9 +
> > drivers/mfd/arizona.h | 5 +
> > drivers/mfd/cs47l24-tables.c | 1632 ++++++++++++++++++++++++++++++++++++++
>
> No chance.
>
> Please resend with these in a header file (like all of the others).
>
> I'd also like Charles' Reviewed-by before accepting.

This looks good to me. I don't quite follow what you are
requesting with the header file? This still uses the header file
for the registers but just defining which are available on this
chip.

Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles


\
 
 \ /
  Last update: 2014-11-13 18:21    [W:0.168 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site