Messages in this thread | | | Date | Thu, 13 Nov 2014 21:54:19 +0800 | Subject | Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position | From | Ganesh Mahendran <> |
| |
2014-11-13 8:02 GMT+08:00 Minchan Kim <minchan@kernel.org>: > On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote: >> In struct zram_table_entry, the element *value* contains obj size and >> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size, >> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj >> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT >> instead of (ZRAM_FLAG_SHIFT + 1). >> >> This patch fixes this issue. >> >> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed" >> >> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com> > Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
> > To be clear about "fixes this issue", it's not a bug but just clean up > so it doesn't change any behavior. > > Thanks! > > -- > Kind regards, > Minchan Kim
| |