Messages in this thread | | | Date | Thu, 13 Nov 2014 10:22:18 +0000 | From | Peter Griffin <> | Subject | Re: [PATCH 07/13] ARM: STi: DT: STiH407: Add usb2 picophy dt nodes |
| |
Hi Lee,
Thanks for reviewing.
On Mon, 10 Nov 2014, Lee Jones wrote: > > + reg = <0xf8 0x04>, /* syscfg 5062 */ > > + <0xf4 0x04>; /* syscfg 5061 */ > > Are there really only 2 32bit registers to control this h/w?
Yes
> > > + reg-names = "param", > > + "ctrl"; > > Superflous indentation after 'reg = ' and 'reg-names = '.
Fixed in v2.
> > + st,syscfg = <&syscfg_core>; > > + resets = <&softreset STIH407_PICOPHY_SOFTRESET>, > > + <&picophyreset STIH407_PICOPHY0_RESET>; > > + reset-names = "global", > > + "port"; > > May as well put these on the same line.
Fixed in v2.
regards,
Peter.
| |