Messages in this thread | | | Date | Wed, 12 Nov 2014 22:18:47 -0200 | From | Henrique de Moraes Holschuh <> | Subject | Re: [PATCH 7/8] x86, microcode, intel: guard against misaligned microcode data |
| |
On Wed, 12 Nov 2014, Borislav Petkov wrote: > On Tue, Nov 11, 2014 at 05:54:00PM -0200, Henrique de Moraes Holschuh wrote: > > void *intel_ucode_kmalloc(size_t size) > > { > > void *p = kmalloc(size, GFP_KERNEL); > > Actually I was thinking of this: > > void *p = kmalloc(size + 16, GFP_KERNEL); > if (!p) > return -ENOMEM; > > if (unlikely((unsigned long)p & 0xf)) > p_a = ALIGN(p, 16); > > You'd need to stash the original *p somewhere for freeing later, of > course.
Well, it is a trade-off: your version always add 16 bytes. Intel microcode is always a multiple of 1KiB, so these extra 16 bytes will often result in allocating an extra page.
The detail is that: since most Intel microcodes are bigger than the kmalloc cache, most of the time kmalloc will return page-aligned addresses, which don't need any alignment.
Your version also needs to keep the original pointer around for kfree, which is going to be annoying.
My version has the drawback that it requires the use of INTEL_UCODE_PTR(p) to get to the microcode data, but you can just kfree(p), and it will only add the 16 bytes when absolutely required. This is nice, because it means we won't waste an extra page in the most common case, and we don't have to find a place to store any extra pointers.
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
| |