lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls
    > > This is especially true if you have trained yourself to know that
    > > free_netdev() can't accept NULL pointers.
    >
    > Do you need to adjust your concerns a bit over time when function variants
    > provide a corresponding safety check in their implementations?

    There would not seem to be any _need_ to do so. An unnecessary null test
    is always safe. The only real problem that I can see with an unnecessary
    null test in error handling code (intrinsically not critical performance
    wise) is if it gives the illusion that a value can be null when it cannot.

    julia


    \
     
     \ /
      Last update: 2014-11-12 23:21    [W:2.175 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site