lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] perf tools: Construct LBR call chain
Date


> > +
> > + printf("... chain: nr:%" PRIu64 "\n", total_nr);
> > +
> > + for (i = 0; i < callchain_nr + 1; i++)
> > printf("..... %2d: %016" PRIx64 "\n",
> > i, sample->callchain->ips[i]);
>
> so if there's lbr callstack info we dont display user stack part from standard
> callchain? I think the dump code should dump out all the info..
>

Right, we don't display user stack part from fp if there is lbr callstack info.
The lbr callstack info can only be captured when the user set --call-graph
lbr. If --call-graph is set to fp and dwarf, there will be no lbr callstack info.

If the user set lbr, I think he really want the lbr info. So I think if we display
both lbr and fp, the fp chain might be meaningless and it will confuse them.
If the user want to do compare, they can do perf record twice with
different --call-graph.


Thanks,
Kan

> jirka


\
 
 \ /
  Last update: 2014-11-12 16:01    [W:0.118 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site