Messages in this thread | | | Date | Wed, 12 Nov 2014 13:29:00 +0100 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH -next 2/2] seq_putc: Convert to return void and convert uses too. |
| |
On Tue, Nov 11, 2014 at 02:47:40PM +0100, Petr Mladek wrote: > On Mon 2014-11-10 10:58:57, Joe Perches wrote: > > Using the return value of seq_putc is error-prone, so > > make it return void instead. > > > > Reverse the logic in seq_putc to make it like seq_puts. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > Reviewed-by: Petr Mladek <pmladek@suse.cz> > > The changes are correct. The show() functions should return 0 > even when there is an overflow. They are called by traverse() > from seq_read() that might increase the buffer size and try again.
Just in case you need this for the netfilter chunks:
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks.
| |