lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 4/5] x86/mce: Simplify flow when handling recoverable memory errors
On Tue, Nov 11, 2014 at 10:22 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Nov 11, 2014 at 09:15:18AM -0800, Andy Lutomirski wrote:
>> Oh -- does it need to sleep?
>
> Oh yeah, iterates over all tasks and generally async access to VM stuff.
> You can have a look if bored: mm/memory-failure.c
>
> :-)
>
>> I find myself wondering whether a much cleaner solution might be to
>> sync regs and switch stacks before invoking do_machine_check rather
>> than afterwards. Then do_machine_check would really be completely
>> non-atomic. It would add a few lines of asm, though.
>
> That's like wagging the dog.

Wagging this particular dog might shake some loose fur off. If we did
this for all paranoid entries, then paranoid_userspace could just be
deleted. :)

>
> I'd prefer much more to actually have a mechanism to do something to
> tasks before scheduling them in.

Like task_work_add?

--Andy


\
 
 \ /
  Last update: 2014-11-11 20:01    [W:0.066 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site