Messages in this thread | | | Date | Mon, 10 Nov 2014 23:34:15 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 1/1] ftruncate, truncate: create fanotify events |
| |
On Mon, Nov 10, 2014 at 09:30:29PM +0100, Jan Kara wrote: > So what I somewhat dislike about this patch is that notify_change() is > sometimes called with dentry and sometimes with path. That way it's not > completely clear when fanotify events will be generated and when not. > Sadly it isn't easy to provide struct path in all the places where we are > calling notify_change() so I'm not sure what would a better solution look > like either :(
I suspect the right thing to do is to split out the truncate path from notify_change, as it's fairly different anyway.
| |