Messages in this thread | | | Date | Tue, 11 Nov 2014 08:39:14 +1000 | Subject | Re: [PATCH 2/2] arm: dts: zynq: Add Digilent ZYBO board | From | Peter Crosthwaite <> |
| |
On Mon, Nov 10, 2014 at 7:47 AM, Sören Brinkmann <soren.brinkmann@xilinx.com> wrote: > Hi Peter, > > On Sun, 2014-11-09 at 01:38PM +1000, Peter Crosthwaite wrote: >> Add a DTS describing the Digilent ZYBO board. Similar to ZED but with > > "Digilent ZYBO" here... > > [...] >> +/ { >> + model = "Zynq ZYBO Development Board"; >> + compatible = "xlnx,zynq-zybo", "xlnx,zynq-7000"; > > ... "xlnx,zynq-zybo" here. Seems inconsistent. IMHO, there should rather be > a digilent vendor prefix. >
Was going for consistency with ZED which also makes this mistake:
model = "Zynq Zed Development Board"; compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
We have to choose between consistency and correctness. If we do fix it though, what is Diglent's four-letter vendor prefix?
Regards, Peter
> Everything else looks pretty straight forward and good. > > Soren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |