Messages in this thread | | | Date | Mon, 10 Nov 2014 22:46:58 +0100 | From | Beniamino Galvani <> | Subject | Re: [PATCH v2 1/2] i2c: add support for Amlogic Meson I2C controller |
| |
On Mon, Nov 10, 2014 at 03:44:41PM +0100, Wolfram Sang wrote: > On Sun, Oct 05, 2014 at 10:17:11PM +0200, Beniamino Galvani wrote: > > This is a driver for the I2C controller found in Amlogic Meson SoCs. > > > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> > > Thanks. Looking very good already! > > > +static void meson_i2c_prepare_xfer(struct meson_i2c *i2c, bool write) > > Instead of the bool, maybe you could query i2c->state in the function? > You decide, I am not forcing you to do this.
Seems reasonable, will do.
> > > +static u32 meson_i2c_func(struct i2c_adapter *adap) > > +{ > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > +} > > Have you tested 0-byte transfers, too (i2cdetect -q)? What was your test > scenario in general?
I did a test with i2cdetect and quick write commands appear to work.
When I wrote the driver I tested it to communicate with the only I2C device available on the board, a Ricoh RN5T618 PMIC.
Now I have access to a hardware with a PCF8564 RTC and just realized that long reads don't work properly, so I'm going to submit a new version of the patchset in the next days.
Thanks, Beniamino
| |