Messages in this thread | | | Date | Mon, 10 Nov 2014 22:47:39 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 2/2] x86, mce: support memory error recovery for both UCNA and Deferred error in machine_check_poll |
| |
On Mon, Nov 10, 2014 at 09:44:26PM +0000, Luck, Tony wrote: > > In fact, you could redo this patch in the meantime without the AMD vendor > > check so that Tony can pick them up soon. I'll add the correct AMD bits > > later. > > You just want this hunk deleted ... > > + if (c->x86_vendor == X86_VENDOR_AMD) { > + /* > + * AMD BKDGs - Machine Check Error Codes > + * > + * Bit 8 of ErrCode[15:0] of MCi_STATUS is used for indicating > + * a memory-specific error. Note that this field encodes info- > + * rmation about memory-hierarchy level involved in the error. > + */ > + return (m->status & 0xff00) == BIT(8); > + } else > > I can do that without a repost. Or I can leave a reminder ... > > + if (c->x86_vendor == X86_VENDOR_AMD) { > + /* > + * coming soon > + */ > + return false; > + } else
Ok, that's fine too. I'll try to have a fix for this very soon so that we can be just in time ready to go for 3.19.
With that you can slap
Acked-by: Borislav Petkov <bp@suse.de>
to them.
Thanks Tony.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |