Messages in this thread | | | Date | Mon, 10 Nov 2014 19:11:14 +0100 | From | Petr Mladek <> | Subject | Re: [RFC][PATCH 07/12 v3] tracing: Have seq_buf use full buffer |
| |
On Fri 2014-11-07 13:37:29, Steven Rostedt wrote: > > Some more touch ups. > > -- Steve > > From 7e724556c21178a9890b31ff57f69761b41f435a Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > Date: Wed, 29 Oct 2014 15:26:09 -0400 > Subject: [PATCH] tracing: Have seq_buf use full buffer > > Currently seq_buf is full when all but one byte of the buffer is > filled. Change it so that the seq_buf is full when all of the > buffer is filled. > > Some of the functions would fill the buffer completely and report > everything was fine. This was inconsistent with the max of size - 1. > Changing this to be max of size makes all functions consistent. > > Link: http://lkml.kernel.org/r/20141104160222.502133196@goodmis.org > > Tested-by: Jiri Kosina <jkosina@suse.cz> > Acked-by: Jiri Kosina <jkosina@suse.cz> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: Petr Mladek <pmladek@suse.cz>
This patch might need a refresh if you add the extra buffer overflow check into seq_buf_set_overflow() in the 3rd patch. Anyway, changes in this patch looks good.
I am happy with all the changes in the patchset. Thanks a lot for driving it forward.
Best Regards, Petr
| |