Messages in this thread | | | Date | Mon, 10 Nov 2014 17:53:43 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled |
| |
On Mon, Nov 10, 2014 at 12:40:19PM +0000, Lee Jones wrote: > On Sun, 02 Nov 2014, Tony Lindgren wrote: > > > Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset > > configuration") enabled configuring the PM features for twl4030. > > > > This caused poweroff command to fail on devices that have the > > BCI charger on twl4030 wired, or have power wired for VBUS. > > Instead of powering off, the device reboots. This is because > > voltage is detected on charger or VBUS with the default bits > > enabled for the power transition registers. > > > > To fix the issue, let's just clear VBUS and CHG bits as we want > > poweroff command to keep the system powered off. > > > > Fixes: e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration") > > Cc: stable@vger.kernel.org # v3.16+ > > Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > Applied to -fixes. > > Not sure whether that was an Ack from Russell or not?
A Tested-by would've been more appropriate than an ack.
-- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
| |