lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] Documentation: Add documentation for rt5033 multifunction device
Thank you for your advice.
I'll fix them and send v2 patch soon.

On 11/07/2014 07:34 PM, Mark Brown wrote:
> On Fri, Nov 07, 2014 at 11:52:07AM +0900, Beomho Seo wrote:
>
>> +Required properties:
>> +- compatible = Must be "richtek,rt5033-regulator"
>> +
>> + regulators {
>> + compatible = "richtek,rt5033-regulator";
>
> There should be no need for this extra compatible, it's not adding
> anything we didn't know from the fact that it's part of the MFD.
>
>> + regulator-name {
>> + regulator-name = LDO/BUCK
>> + standard regulator constraints...
>> + };
>
> Better to just say something like "regulator subnodes called X, Y and Z"
> described using the standard regulator binding in...
>

Best regards,
Beomho Seo


\
 
 \ /
  Last update: 2014-11-10 07:21    [W:0.081 / U:3.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site