Messages in this thread | | | Date | Mon, 10 Nov 2014 14:40:57 +0900 | From | Beomho Seo <> | Subject | Re: [PATCH 5/5] Documentation: Add documentation for rt5033 multifunction device |
| |
Thank you for your advice. I'll fix them and send v2 patch soon.
On 11/07/2014 07:34 PM, Mark Brown wrote: > On Fri, Nov 07, 2014 at 11:52:07AM +0900, Beomho Seo wrote: > >> +Required properties: >> +- compatible = Must be "richtek,rt5033-regulator" >> + >> + regulators { >> + compatible = "richtek,rt5033-regulator"; > > There should be no need for this extra compatible, it's not adding > anything we didn't know from the fact that it's part of the MFD. > >> + regulator-name { >> + regulator-name = LDO/BUCK >> + standard regulator constraints... >> + }; > > Better to just say something like "regulator subnodes called X, Y and Z" > described using the standard regulator binding in... >
Best regards, Beomho Seo
| |