Messages in this thread | | | Date | Sat, 01 Nov 2014 15:03:19 +0300 | From | "Matwey V. Kornilov" <> | Subject | Re: [PATCH] Documentation: Restrict TSC test code to x86 |
| |
28.10.2014 16:12, Alexander Graf пишет: > > > >> Am 28.10.2014 um 13:47 schrieb Jonathan Corbet <corbet@lwn.net>: >> >> On Mon, 27 Oct 2014 20:07:51 -0400 >> Peter Foley <pefoley2@pefoley.com> wrote: >> >>>> The prctl test code in Documentation/ tries to show how to >>>> use a call that only makes sense on x86. Restrict it there >>>> so that other platforms don't try to call asm("rdtsc"). >>>> >>>> Signed-off-by: Alexander Graf <agraf@suse.de> >>> >>> Acked-by: Peter Foley <pefoley2@pefoley.com> >> >> Snagged into the docs tree, thanks. > > Awesome, please make sure this makes it into 3.18 - the build is broken on non-x86 archs there ;). > > Alex >
Hi,
Sorry for criticism, but the patch is not complete. CONFIG_X86 deals with target architecture, at the same time the problem deals with the host architecture.
Imagine, that I run arm, aarch64 or something else and do cross-compiling kernel for x86 on it. Then CONFIG_X86 will evaluate to 'y' and make will try to compile the apps with the host-compiler, which is not x86 one.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |