lkml.org 
[lkml]   [2014]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch: tile: kernel: signal.c: Use explicitly type case "unsigned long *" for register copy
On 11/2/14 4:23, Al Viro wrote:
> On Sat, Nov 01, 2014 at 08:49:45PM +0800, Chen Gang wrote:
>> setup_sigcontext() wants to copy all kernel related registers to user
>> space. So let it copy explicitly instead of copying by exceeding member
>> array border. So let code more clearer and avoid warning.
>
> Er... Perhaps it would be better to avoid that shite completely and just
> use __copy_to_user() instead of bothering with loops?
>

OK, thanks, I shall send patch v2 for it.

Also use __copy_from_user() instead of the code in restore_sigcontext().

Thanks
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed


\
 
 \ /
  Last update: 2014-11-02 03:21    [W:1.723 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site