Messages in this thread | | | Date | Sun, 02 Nov 2014 10:02:14 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] arch: tile: kernel: signal.c: Use explicitly type case "unsigned long *" for register copy |
| |
On 11/2/14 4:23, Al Viro wrote: > On Sat, Nov 01, 2014 at 08:49:45PM +0800, Chen Gang wrote: >> setup_sigcontext() wants to copy all kernel related registers to user >> space. So let it copy explicitly instead of copying by exceeding member >> array border. So let code more clearer and avoid warning. > > Er... Perhaps it would be better to avoid that shite completely and just > use __copy_to_user() instead of bothering with loops? >
OK, thanks, I shall send patch v2 for it.
Also use __copy_from_user() instead of the code in restore_sigcontext().
Thanks -- Chen Gang
Open, share, and attitude like air, water, and life which God blessed
| |