lkml.org 
[lkml]   [2014]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='
On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote:
> On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote:
> > On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
> > > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
> > > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
> > > > and ft1000/ft1000-pcmcia/ft1000_hw.c:
> > > > ERROR: spaces required around that '=' (ctx:VxV)
> > > > ERROR: spaces required around that '<' (ctx:VxV)
> > > > ERROR: spaces required around that '==' (ctx:VxV)
> > > >
> > >
> > > many whitespace errors in the patch.
> > > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
> >
> > When fixing one thing (like spacing), it's pretty
> > expected to have more checkpatch errors.
> >
> > It's a process, don't worry about most intermediate
> > warnings when doing checkpatch cleanups.
> >
> > Adding trailing spaces is not good, nearly every
> > other type of message can be ignored.
> >
> ok, just to verify, i thought of trying to generate a similar patch which will not give checkpatch errors.
> but this patch is not applying to next-20141031.
>
> thanks
> sudip

looks like Nicky Chorley has already done part of this cleanup and it was also applied on 26/10/2014.

thanks
sudip


\
 
 \ /
  Last update: 2014-11-01 07:01    [W:0.093 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site