Messages in this thread | | | Date | Thu, 9 Oct 2014 14:54:41 -0700 | From | Omar Sandoval <> | Subject | Re: [PATCH] net sched: text ematch: zero out ts_state before using it |
| |
On Thu, Oct 09, 2014 at 02:48:54PM -0700, Cong Wang wrote: > On Thu, Oct 9, 2014 at 9:05 AM, Omar Sandoval <osandov@osandov.com> wrote: > > textsearch_find zeroes out the offset, but the control buffer (which may or may > > not matter in this case) needs to be zeroed out as well. > > Why? skb_prepare_seq_read() initializes the cb. > > Also, the comment says: > > * @state: uninitialized textsearch state variable
Mm, thanks, I missed that. It looks like every other caller of skb_find_text is doing an unnecessary memset in that case. Disregard this, I guess. -- Omar
| |