Messages in this thread | | | Date | Thu, 9 Oct 2014 13:14:31 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] ARM: meson: watchdog: remove magic value for reboot |
| |
On Thu, Oct 09, 2014 at 09:59:16PM +0200, Carlo Caione wrote: > This patch removes the magic value used for rebooting the board. This > value is useless and leads to a static checker warning as reported by > Dan Carpenter. > > Signed-off-by: Carlo Caione <carlo@caione.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/meson_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c > index 37f9f5ec..ef6a298 100644 > --- a/drivers/watchdog/meson_wdt.c > +++ b/drivers/watchdog/meson_wdt.c > @@ -51,7 +51,7 @@ struct meson_wdt_dev { > static int meson_restart_handle(struct notifier_block *this, unsigned long mode, > void *cmd) > { > - u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN | 100; > + u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN; > struct meson_wdt_dev *meson_wdt = container_of(this, > struct meson_wdt_dev, > restart_handler); > -- > 1.9.1 >
| |