Messages in this thread | | | Date | Thu, 9 Oct 2014 09:28:29 -0700 | From | Omar Sandoval <> | Subject | Re: [PATCH] net sched: text ematch: zero out ts_state before using it |
| |
On Thu, Oct 09, 2014 at 09:05:21AM -0700, Omar Sandoval wrote: > textsearch_find zeroes out the offset, but the control buffer (which may or may > not matter in this case) needs to be zeroed out as well. > > Signed-off-by: Omar Sandoval <osandov@osandov.com> > --- > net/sched/em_text.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/sched/em_text.c b/net/sched/em_text.c > index 15d353d..2a1b6d9 100644 > --- a/net/sched/em_text.c > +++ b/net/sched/em_text.c > @@ -36,6 +36,8 @@ static int em_text_match(struct sk_buff *skb, struct tcf_ematch *m, > int from, to; > struct ts_state state; > > + memset(&state, 0, sizeof(state)); > + > from = tcf_get_base_ptr(skb, tm->from_layer) - skb->data; > from += tm->from_offset; > > -- > 2.1.2 >
I forgot to mention: this patch is against 3.17.
-- Omar
| |