Messages in this thread | | | Date | Thu, 09 Oct 2014 15:38:41 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 2/2] ALSA: au88x0: pr_* replaced with dev_* |
| |
At Thu, 9 Oct 2014 15:06:37 +0530, Sudip Mukherjee wrote: > > pr_* macros replaced with dev_* as they are more preffered over pr_*. > each file which had pr_* was reviewed manually and replaced with dev_*. > here we have actually used the reference of the vortex which was added > to some functions in the previous patch of this series. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > sound/pci/au88x0/au88x0.c | 26 +++++----- > sound/pci/au88x0/au88x0_a3d.c | 15 +++--- > sound/pci/au88x0/au88x0_core.c | 103 ++++++++++++++++++++++----------------- > sound/pci/au88x0/au88x0_eq.c | 3 +- > sound/pci/au88x0/au88x0_game.c | 3 +- > sound/pci/au88x0/au88x0_mpu401.c | 2 +- > sound/pci/au88x0/au88x0_pcm.c | 7 +-- > sound/pci/au88x0/au88x0_synth.c | 17 ++++--- > 8 files changed, 98 insertions(+), 78 deletions(-) > > diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c > index 21ce31f..ea66cee 100644 > --- a/sound/pci/au88x0/au88x0.c > +++ b/sound/pci/au88x0/au88x0.c > @@ -48,10 +48,10 @@ static void vortex_fix_latency(struct pci_dev *vortex) > { > int rc; > if (!(rc = pci_write_config_byte(vortex, 0x40, 0xff))) { > - pr_info( CARD_NAME > + dev_info(&vortex->dev, CARD_NAME > ": vortex latency is 0xff\n");
Omit the superfluous prefix when converting to dev_info() & co. Other than that, looks good to me.
thanks,
Takashi
| |