Messages in this thread | | | Date | Thu, 9 Oct 2014 19:28:53 +0900 | Subject | Re: [PATCH V2] staging: dgap: introduce dgap_stop() | From | DaeSeok Youn <> |
| |
Hi,
2014-10-09 19:23 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>: > On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote: >> On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote: >> > The dgap_init_module() need to unwind for cleanup variables properly. >> > Because dgap_init_module() calls dgap_cleanup_module() for freeing >> > variables but this function is possible to free variables >> > which are not allocated. >> > >> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> >> > --- >> > V2: change ulong which is non-standard to "unsigned long". >> I think , Dan, in his review of your v1 , asked you to rearrange the functions and get rid of the forward declarations. >> > > I was fine with v1 actually... It's a bug fix, and this is staging and > there are tons of forward declarations already. Eventually we need to > get rid of them but it can be done later. Yes, I will cleanup as your review.
thanks.
regards, Daeseok Youn.
> > regards, > dan carpenter >
| |