Messages in this thread | | | Date | Wed, 8 Oct 2014 09:11:12 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC |
| |
On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote: > +static void __init bcm_cygnus_init(void) > +{ > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > + > + l2x0_of_init(0, ~0UL);
Please don't explicitly call l2x0 initialisation. Instead, set the appropriate l2c members here:
> +DT_MACHINE_START(BCM_CYGNUS_DT, "Broadcom Cygnus SoC") > + .init_machine = bcm_cygnus_init, > + .map_io = debug_ll_io_init, > + .dt_compat = bcm_cygnus_dt_compat, > + .restart = bcm_cygnus_restart > +MACHINE_END
and let the core code call it at the appropriate time. Thanks.
-- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
| |