Messages in this thread | | | Date | Wed, 8 Oct 2014 21:04:26 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/4] Input: pmic8xxx-keypad - use regmap_field for register access |
| |
On Wed, Oct 08, 2014 at 11:20:58AM -0700, Stephen Boyd wrote: > On 10/08/2014 11:13 AM, Dmitry Torokhov wrote:
> >>>Oops. struct regmap_field is opaque. It seems that the allocation > >>>is the only way that I could have instance of it.
> >>Maybe we can add an API to allocate an array of fields?
> >Maybe we could make the structure public instead? I do not see any > >reason for allocating something separately that has exactly the same > >lifetime as owning structure.
The lifetime may be different to that of the register map it references, consider MFD function devices for example.
> Srini/Mark, any reason why the regmap_field structure is opaque?
So you can't peer into it and rely on the contents. I can see it being useful to add a bulk allocator. [unhandled content-type:application/pgp-signature] | |